added path support #20
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 67.75% 67.57% -0.18%
==========================================
Files 6 7 +1
Lines 428 475 +47
==========================================
+ Hits 290 321 +31
- Misses 124 140 +16
Partials 14 14
Continue to review full report at Codecov.
|
path.go
Outdated
| Nodes []interface{} | ||
| Edges []interface{} |
There was a problem hiding this comment.
Nodes []Node
Edges []Edge
we've got both an Edge and Node structs.
There was a problem hiding this comment.
changed to []*Node and []*Edge
| Edges []interface{} | ||
| } | ||
|
|
||
| func PathNew(nodes []interface{}, edges []interface{}) Path { |
There was a problem hiding this comment.
func PathNew(nodes []Node, edges []Edge) Path {
There was a problem hiding this comment.
the constructor will convert from array of interface to array of node/edge
path.go
Outdated
| } | ||
| } | ||
|
|
||
| func (p Path) GetNodes() []interface{} { |
There was a problem hiding this comment.
func (p Path) GetNodes() []Node {
path.go
Outdated
| return p.Nodes | ||
| } | ||
|
|
||
| func (p Path) GetEdges() []interface{} { |
There was a problem hiding this comment.
func (p Path) GetEdges() []Edge {
| } | ||
|
|
||
| func (p Path) FirstNode() *Node { | ||
| return p.GetNode(0) |
There was a problem hiding this comment.
What if the Path is empty?
path.go
Outdated
| } | ||
|
|
||
| func (p Path) GetNode(index int) *Node { | ||
| return p.Nodes[index].(*Node) |
There was a problem hiding this comment.
Index validations?
index >=0 && index < Path length ?
| } | ||
|
|
||
| func (p Path) LastNode() *Node { | ||
| return p.GetNode(p.NodesCount() - 1) |
path.go
Outdated
| return len(p.Edges) | ||
| } | ||
|
|
||
| func (p Path) Encode() string { |
There was a problem hiding this comment.
https://play.golang.org/p/Azql7_pDAA
func (p Path) String() string {...
README.md
Outdated
| res.Next() | ||
| r := res.Record() | ||
| p, ok := r.GetByIndex(0).(Path) | ||
| fmt.Printf("%v", p.Encode()) |
| arrays := cell.([]interface{}) | ||
| nodes := qr.parseScalar(arrays[0].([]interface{})) | ||
| edges := qr.parseScalar(arrays[1].([]interface{})) | ||
| return PathNew(nodes.([]interface{}), edges.([]interface{})) |
There was a problem hiding this comment.
return PathNew(nodes, edges)
There was a problem hiding this comment.
should be an array
No description provided.