Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for []string within ToString() function #49

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

filipecosta90
Copy link
Contributor

This PR closes the missing gap to fix #30. The map support was already addressed by @AvitalFineRedis on #47 so we just need to support []string type within ToString() function.
Included as a test the use-case raised on #30 by @sankarvj

@filipecosta90 filipecosta90 added the bug Something isn't working label Jun 2, 2021
Copy link
Contributor

@jeffreylovitz jeffreylovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me!

@jeffreylovitz jeffreylovitz merged commit 2a1d063 into master Jun 2, 2021
@jeffreylovitz jeffreylovitz deleted the support.string.slice.params branch June 2, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List/Map types not supported in properties
2 participants