Prevents the program from entering endless loop #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hbina, thanks for this PR. Did you consider fixing the root cause of the problem? |
|
From what I understand, this seems like am expected behavior. If I am requesting 5 request and also say I will reset at every 5 request, I will just do this endlessly. Maybe I am wrong. |
|
@hbina reconnect-interval specifies a maximum number of commands to execute on a connection before dropping it and re-establishing a new one. I believe it's just a bug in the implementation, but you are more than welcome to take a look for yourself. Thanks! |
|
Okay, I will take a look. |
The application will no longer abort but instead perform the benchmark without entering the endless loop. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
hbina
force-pushed
the
prevent_endless_loop_reconnect_interval_requests
branch
from
193523d to
722ccac
Compare
|
Is this correct? I hope I am not messing with other stuff. This does prevent the endless loop |
yossigo
approved these changes
Oct 26, 2020
|
@hbina Thank you, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #135
The fix is simple enough, we just abort if we detect this particular
setting.
Signed-off-by: Hanif Bin Ariffin hanif.ariffin.4326@gmail.com