Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the option to edit protected configs #200

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Oct 5, 2023

As of redis 7.0, some configurations in redis as considered protected (such as dbfilename) and cannot be modified in run time, unless the --enable-protected-configs configuration (which is immutable) is set to yes (or local).
Here we add the option to set --enable-protected-configs yes in redis with a new parameter.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9548544) 33.54% compared to head (ff39f43) 34.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   33.54%   34.07%   +0.52%     
==========================================
  Files          17       17              
  Lines        2382     2389       +7     
==========================================
+ Hits          799      814      +15     
+ Misses       1583     1575       -8     
Flag Coverage Δ
unittests 34.07% <66.66%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
RLTest/env.py 58.56% <100.00%> (+0.20%) ⬆️
RLTest/redis_std.py 58.44% <80.00%> (+2.45%) ⬆️
RLTest/__main__.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DvirDukhan
DvirDukhan previously approved these changes Oct 5, 2023
@alonre24 alonre24 merged commit 262b22a into master Oct 9, 2023
22 checks passed
@alonre24 alonre24 deleted the enable_edit_protected_configs branch October 9, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants