Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Added support for DUPLICATE_POLICY / ON_DUPLICATE keywords ( TS.INFO update accordingly ) #66

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

filipecosta90
Copy link
Collaborator

Fixes #65

  • This PR follows the General Availability release for RedisTimeSeries 1.4 and the ability to back-fill time series.
  • It also also moves towards making usage of keyword variadic arguments on touched functions just to make the code cleaner and less error prone.
  • Apart from it, it enables coverage to be run on forked PR ( given that we want to know coverage diffs on community PRs as well ).

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #66 into master will decrease coverage by 0.16%.
The diff coverage is 97.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   98.31%   98.15%   -0.17%     
==========================================
  Files           2        2              
  Lines         416      487      +71     
==========================================
+ Hits          409      478      +69     
- Misses          7        9       +2     
Impacted Files Coverage Δ
test_commands.py 97.25% <94.73%> (-0.48%) ⬇️
redistimeseries/client.py 99.13% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040eaa2...f9c7392. Read the comment docs.

@@ -58,8 +58,6 @@ jobs:
. venv/bin/activate
REDIS_PORT=6379 coverage run test_commands.py

- early_return_for_forked_pull_requests
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipecosta90 not sure about this one. is this on purpose?

@filipecosta90 filipecosta90 merged commit b451b43 into master Sep 21, 2020
@filipecosta90 filipecosta90 added the enhancement New feature or request label Nov 29, 2020
@filipecosta90 filipecosta90 deleted the duplicate.policy.support branch November 29, 2020 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants