Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support const and examples #10

Merged
merged 1 commit into from
Jun 19, 2019
Merged

feat: support const and examples #10

merged 1 commit into from
Jun 19, 2019

Conversation

csimi
Copy link
Contributor

@csimi csimi commented Jun 5, 2019

const was added in JSON schema draft 6: https://json-schema.org/understanding-json-schema/reference/generic.html#constant-values
I see that "example" is supported on the OpenAPI level but it should also be supported in the JSON schema: https://json-schema.org/understanding-json-schema/reference/generic.html#annotations

@XVincentX
Copy link

@RomanHotsiy Any chance to get this merged?

@RomanHotsiy
Copy link
Member

Sorry, super busy. I will check this on weekends

@XVincentX
Copy link

Fantastic — this would really help us!

@XVincentX
Copy link

@RomanHotsiy Have you been able to check this out?

@RomanHotsiy RomanHotsiy merged commit 77b8fb2 into Redocly:master Jun 19, 2019
@RomanHotsiy
Copy link
Member

LGTM 👍 Thanks.
Will release a new version on weekends.

@RomanHotsiy
Copy link
Member

fyi: already released 1.0.0-beta.15

@XVincentX
Copy link

Oh fantastic, I'll try this out!

@XVincentX
Copy link

@RomanHotsiy I can't find it on npm 🤔

@RomanHotsiy
Copy link
Member

Whoops, looks like I have to update npm key on Travis. Deployed manually. Should be on npm already!

RomanHotsiy pushed a commit that referenced this pull request May 25, 2021
* feat: add more formats

* chore: pr feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants