fix: escape backslashes in string literals (#823)

Follow up for #822 and 0473165 (only escape quotes).
Redocly · Feb 26, 2019 · 70faca1 · 70faca1
1 parent 3ce5bff
commit 70faca1
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/utils/jsonToHtml.ts b/src/utils/jsonToHtml.ts
@@ -21,8 +21,8 @@ function htmlEncode(t) {
     : '';
 }
 
-function escapeStringQuotes(str: string) {
-  return str.replace(/"/g, '\\"');
+function escapeForStringLiteral(str: string) {
+  return str.replace(/([\\"])/g, '\\$1');
 }
 
 function decorateWithSpan(value, className) {
@@ -57,11 +57,11 @@ function valueToHTML(value) {
         '<a href="' +
         value +
         '">' +
-        htmlEncode(escapeStringQuotes(value)) +
+        htmlEncode(escapeForStringLiteral(value)) +
         '</a>' +
         decorateWithSpan('"', 'token string');
     } else {
-      output += decorateWithSpan('"' + escapeStringQuotes(value) + '"', 'token string');
+      output += decorateWithSpan('"' + escapeForStringLiteral(value) + '"', 'token string');
     }
   } else if (valueType === 'boolean') {
     output += decorateWithSpan(value, 'token boolean');