Mis-nesting of aria roles on sidebar navigation (#2050)

Redocly · Jun 20, 2022 · 7ca10da · 7ca10da
1 parent 01ffff7
commit 7ca10da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/e2e/integration/search.e2e.ts b/e2e/integration/search.e2e.ts
@@ -45,7 +45,7 @@ describe('Search', () => {
 
     getSearchInput().type('{enter}', { force: true });
 
-    cy.contains('[role=navigation] [role=menuitem]', 'Introduction').should('have.class', 'active');
+    cy.contains('[role=menu] [role=menuitem]', 'Introduction').should('have.class', 'active');
   });
 
   it('should mark search results', () => {

diff --git a/src/components/SideMenu/MenuItems.tsx b/src/components/SideMenu/MenuItems.tsx
@@ -26,7 +26,7 @@ export class MenuItems extends React.Component<MenuItemsProps> {
         className={className}
         style={this.props.style}
         expanded={expanded}
-        {...(root ? { role: 'navigation' } : {})}
+        {...(root ? { role: 'menu' } : {})}
       >
         {items.map((item, idx) => (
           <MenuItem key={idx} item={item} onActivate={this.props.onActivate} />