fix: improve code

Redocly · May 31, 2021 · 9fdcdfb · 9fdcdfb
1 parent 532c30e
commit 9fdcdfb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/src/services/models/Schema.ts b/src/services/models/Schema.ts
@@ -196,7 +196,7 @@ export class SchemaModel {
       const title =
         isNamedDefinition(variant.$ref) && !merged.title
           ? JsonPointer.baseName(variant.$ref)
-          : (merged.const && JSON.stringify(merged.const)) || merged.title;
+          : `${(merged.title || '')}${(merged.const && JSON.stringify(merged.const)) || ''}`;
 
       const schema = new SchemaModel(
         parser,

diff --git a/src/utils/__tests__/openapi.test.ts b/src/utils/__tests__/openapi.test.ts
@@ -227,6 +227,19 @@ describe('Utils', () => {
       expect(isPrimitiveType(schema)).toEqual(false);
     });
 
+    it('should return true for array contains array of strings', () => {
+      const schema = {
+        type: 'array',
+        items: {
+            type: 'array',
+            items: {
+              type: 'string'
+            },
+        },
+      };
+      expect(isPrimitiveType(schema)).toEqual(true);
+    });
+
     it('Should return false for array of string which include the null value', () => {
       const schema = {
         type: ['object', 'string', 'null'],

diff --git a/src/utils/openapi.ts b/src/utils/openapi.ts
@@ -126,7 +126,7 @@ export function isPrimitiveType(schema: OpenAPISchema, type: string | string[] |
   }
 
   if (schema.items !== undefined && (type === 'array' || (isArray && type?.includes('array')))) {
-    isPrimitive = false;
+    isPrimitive = isPrimitiveType(schema.items, schema.items.type);
   }
 
   return isPrimitive;