fix: more cases for react18 and cli integration #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oprysk
approved these changes
Sep 15, 2023
AlexVarchuk
approved these changes
Sep 15, 2023
ckoegel
pushed a commit
to Bandwidth/redoc
that referenced
this pull request
Nov 1, 2023
This was referenced Jul 16, 2024
This was referenced Jul 25, 2024
This was referenced Aug 1, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Following this fix I found a few more cases where boolean props are being passed to the DOM. This MR makes them transient as well.
Reference
Tests
Tested locally with different API descriptions.
Screenshots (optional)
Check yourself