Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more cases for react18 and cli integration #2416

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Sep 14, 2023

What/Why/How?

Following this fix I found a few more cases where boolean props are being passed to the DOM. This MR makes them transient as well.

Reference

Tests

Tested locally with different API descriptions.

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@tatomyr tatomyr self-assigned this Sep 14, 2023
@tatomyr tatomyr marked this pull request as ready for review September 15, 2023 10:15
@tatomyr tatomyr requested a review from a team as a code owner September 15, 2023 10:15
@Oprysk Oprysk merged commit 26674e7 into main Sep 15, 2023
6 checks passed
@Oprysk Oprysk deleted the fix/react18-in-cli branch September 15, 2023 10:28
ckoegel pushed a commit to Bandwidth/redoc that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants