-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally render object schema title and descriptions #1497
base: main
Are you sure you want to change the base?
Conversation
cc0c845
to
3c4ece9
Compare
@RomanHotsiy Would you spend some time to review this PR? |
Hey @aleung! Thanks for your PR and thanks for a ping! I'll try to review it on weekends. |
Hey @aleung, The PR looks great! thanks. I just don't fully like the UI part of it (especially the h3 heading). Let me play with it on weekends and I'll merge it. Sorry for the delay, this should be merged soon. |
👀 |
This would be a very useful feature! Hope to see it merged soon. |
Hey @aleung... Sorry, we're super busy 🙈... We definitely plan to add support for this but a little bit later. Before, we want to clean up other PRs and release 2.0. |
@RomanHotsiy Understood. Please let me know when you need me to rebase the PR on latest. |
@aleung. Not. We'll ping you when we're done with the release. |
It's a pity this never got merged. It was certainly helpful. |
Is there any chance to get this merged? 2.x appears to be out by now. Or are there other ways to achieve this? |
2505d81
to
6338fdc
Compare
This PR is 4 years old. The main branch has a lot of changes and the merge conflict is difficult to resolve. I have managed to re-apply the changes on the latest main branch. I must admit that the UI implementation is an ugly hack, and I lack expertise in UI development. I hope someone from Redocly could assist in improving it to align with the overall look and feel. I am optimistic that this PR will be reviewed and merged. |
For anyone who wants to use this feature, you can temporarily use my fork before this pull request gets merged. |
It's a followup of #1035. Fixes #598, #720, #752.
Shown in operations but hidden in <SchemaDefinition> by default.
Before the fix:
After the fix: