Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance search feature to support path #2145

Merged
merged 8 commits into from
Sep 6, 2022
Merged

Enhance search feature to support path #2145

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4fe22ca
Make paths searchable
bpateldx Aug 29, 2022
7eb2bbd
Merge pull request #1 from bpateldx/feature/support-search-for-paths
bpateldx Aug 30, 2022
73e223e
Updated changelog
bpateldx Aug 30, 2022
0f173eb
Removed changelog as requested
bpateldx Aug 30, 2022
2be56f3
Reverted back to original master version
bpateldx Aug 30, 2022
d741de8
Trim terms same way while indexing and querying
bpateldx Aug 31, 2022
38a702a
Merge pull request #2 from bpateldx/bug-fix/tokens-not-trimmed-for-se…
bpateldx Sep 1, 2022
c5dca6d
Merge branch 'Redocly:master' into master
bpateldx Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions e2e/integration/search.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ describe('Search', () => {
.first()
.should('contain', 'Introduction');

getSearchInput().clear().type('uploadImage', { force: true });
cy.get('[role=search] [role=menuitem]')
.should('have.length', 1)
.first()
.should('contain', 'uploads an image');

getSearchInput().type('{esc}', { force: true });
getSearchResults().should('not.exist');
});
Expand Down
2 changes: 1 addition & 1 deletion src/services/SearchStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class SearchStore<T> {
const recurse = items => {
items.forEach(group => {
if (group.type !== 'group') {
this.add(group.name, group.description || '', group.id);
this.add(group.name, (group.description || '').concat(' ', group.path || ''), group.id);
}
recurse(group.items);
});
Expand Down