Improve accessible label by using the property name #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagfs
requested review from
anastasiia-developer
and removed request for
a team
RomanHotsiy
approved these changes
Dec 29, 2022
ckoegel
pushed a commit
to Bandwidth/redoc
that referenced
this pull request
Jun 6, 2023
This was referenced Jul 16, 2024
This was referenced Jul 25, 2024
This was referenced Aug 1, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Fixes #2223
Summary: Labels and accessible labes should correspond. The use of
expand propertyinstead ofexpand {name}breaks this WCAG rule.Reference
Testing
Testing the issue this PR resolves requires using SiteImprove or the SiteImprove Chrome extension
AND it requires using another example than the PetStore as it for some reason crashes the extension.
I have tried outlining the issue i the issue and have tested that this change resolves the issue locally.
Screenshots (optional)
Check yourself
I'm not able to get this projects test running fully locally. Problems with
update-notifiereven after trying to bind it and change node versions. As I understood it there are some problems with this module currently?If you have any tips for how to resolve this problem I can test it again 😄