Move role to list item to meet ARIA spec #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
approved these changes
Dec 29, 2022
ckoegel
pushed a commit
to Bandwidth/redoc
that referenced
this pull request
Jun 6, 2023
This was referenced Jul 16, 2024
This was referenced Jul 25, 2024
This was referenced Aug 1, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
To meet SiteImprove checks #2227
Reference
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role
Testing
Screenshots (optional)
No visual change
Check yourself
I'm still not able to run the tests locally. But this should not affect the tests