Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for minItems and maxItems constraint humanization #700

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Add support for minItems and maxItems constraint humanization #700

merged 3 commits into from
Nov 5, 2018

Conversation

lscholten
Copy link
Contributor

According to #42 , minItems and maxItems are not yet rendered in the documentation.
This pull request shows the humazined form of minItems and maxItems next to the type description.
The suggestion of fgabolde is followed and "characters" is simply replaced with "items".

image

Some examples are added to the demo.

@RomanHotsiy
Copy link
Member

@lscholten nice!

Could you please add a simple test to test it?

Thanks in advance!

@coveralls
Copy link

coveralls commented Nov 5, 2018

Coverage Status

Coverage increased (+0.2%) to 82.16% when pulling 8ec1147 on lscholten:master into 9e2853c on Rebilly:master.

@RomanHotsiy RomanHotsiy merged commit f40568b into Redocly:master Nov 5, 2018
@RomanHotsiy
Copy link
Member

Awesome 👍
Thanks a lot!

@lscholten lscholten changed the title Add support for minLength and maxLength constraint humanization Add support for minItems and maxItems constraint humanization Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants