Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported keyword OAS 3.0.x typing - additionalItems #1609

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

jeremyfiel
Copy link
Contributor

related #707

What/Why/How?

This is a JSON Schema keyword but IS NOT supported by OpenAPI 3.0.x. This type was incorrectly added to the Schema object typings.

Reference

related OAI/OpenAPI-Specification#741 (comment)

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@jeremyfiel jeremyfiel requested review from a team as code owners July 3, 2024 22:38
Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 18bf3c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@HCloward HCloward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release note looks good to me.

Copy link
Contributor

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeremyfiel!

@tatomyr tatomyr merged commit 97302b8 into Redocly:main Jul 11, 2024
27 checks passed
jeremyfiel added a commit to jeremyfiel/redocly-cli that referenced this pull request Jul 16, 2024
…cly#1609)


Co-authored-by: Jeremy Fiel <jeremy.fiel@adp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants