-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve plugins from npm packages correctly #1749
Conversation
🦋 Changeset detectedLatest commit: 8c43dd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Test suite run success809 tests passing in 121 suites. Report generated by 🧪jest coverage report action from 8c43dd2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left an optional suggestion. Otherwise looks good.
This reverts commit 6e412fd.
fd38cca
to
8c43dd2
Compare
What/Why/How?
When the CLI is installed globally and tries to resolve a plugin from NPM package, it can't find it because by default the
require.resolve
tries to look for the package from the CLI installation location. This would cause errors like below even though the plugin package is installed in the project'snode_modules
directory:Added the config directory as an additional path to look for NPM packages when resolving plugins.
Reference
Reported in internal conversation
Testing
Screenshots (optional)
Check yourself
Security