-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st misc bugs batch #947
Merged
Spartan322
merged 30 commits into
Redot-Engine:4.3
from
Spartan322:4.3.1-cherry-pick/bugs-misc
Jan 23, 2025
Merged
[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st misc bugs batch #947
Spartan322
merged 30 commits into
Redot-Engine:4.3
from
Spartan322:4.3.1-cherry-pick/bugs-misc
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPUParticles' Inherit Velocity property used to act strangely if the physics tick rate was lower than the rendered FPS, as velocity was tracked in the process and not in the physics process. This means that on certain rendered frames, the velocity was effectively 0 since there was no movement since the last rendered frame. (cherry picked from commit 33e1f57)
(cherry picked from commit db2e09e)
(cherry picked from commit 202e197)
* AStar2D, AStar3D and AStarGrid2D will now return a path when allow_partial_path is true even if the destination is a solid/disabled point. # Conflicts: # core/math/a_star_grid_2d.cpp # core/math/a_star_grid_2d.h (cherry picked from commit c46b5af)
Spartan322
added
bug
enhancement
platform:web
platform:linuxbsd
platform:windows
platform:android
topic:core
platform:macos
topic:porting
topic:thirdparty
topic:physics
topic:dotnet
topic:xr
topic:import
topic:input
topic:navigation
topic:tests
topic:2d
topic:animation
performance
topic:3d
topic:particles
labels
Jan 23, 2025
Use the DLL instead of the EXE, so we can rely on the dotnet CLI handling the architecture. (cherry picked from commit ec189b1)
When compressing animation key frame indices the truncation breaks the animation near the border of pages. We use banker's rounding (FE_TONEAREST) as implemented by fast_ftoi to get the nearest integer frame. (cherry picked from commit dd9525b)
(cherry picked from commit 4431af9)
(cherry picked from commit 77dab88)
(cherry picked from commit 4113529)
(cherry picked from commit 5adb489)
(cherry picked from commit e2386de)
(cherry picked from commit 771e561)
(cherry picked from commit dc3de73)
(cherry picked from commit 5d1a2a4)
(cherry picked from commit a59fb07)
(cherry picked from commit 3de62b8)
…esGenerator (cherry picked from commit 186f35f)
(cherry picked from commit 8bb3e53)
(cherry picked from commit 24d51f7)
(cherry picked from commit f8f5505)
(cherry picked from commit 7c6f523)
(cherry picked from commit 56922db)
(cherry picked from commit 652db79)
(cherry picked from commit d54229d)
(cherry picked from commit 78883a5)
(cherry picked from commit d9ad5d1)
Spartan322
force-pushed
the
4.3.1-cherry-pick/bugs-misc
branch
from
January 23, 2025 02:59
2f60f9a
to
05bffa8
Compare
tindrew
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc Bug PRs:
allow_partial_path
option godotengine/godot#94246OpenVisualStudio.dll
godotengine/godot#97198InputEventKey
test failure under certain system languages godotengine/godot#98504GodotSpace3D::test_body_motion()
not settinglocal_shape
godotengine/godot#99901backward
be parameter of theAnimationTree
in theAnimationNodeAnimation
godotengine/godot#100039Extra PRs:
AStarGrid2D
godotengine/godot#91868AStarGrid2D
performance when jumping is enabled godotengine/godot#93319JavaClassWrapper
so it actually works godotengine/godot#96182