Updating the mod-base to 1.20.4 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….gradle, and fabric.mod.json were changed to account for any versioning. Then the command "gradlew migrateMappings --mappings "1.20.4+build.3" was run to fix mixin errors. After that, the Gradle was updated from 8.1.1 to 8.5 due to a need by 1.20.4 Fabric. Finally, the migrateMappings command made a new src folder and copied everything over with the fixed mixins. As such I've named the old src file "oldSrc" until we decide to delete it.
RUGMJ
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the push to update the mod to 1.20.4, the gradle.properties, build.gradle, and fabric.mod.json were changed to account for any versioning.
Then the command "gradlew migrateMappings --mappings "1.20.4+build.3" was run to fix mixin errors. After that, the Gradle was updated from 8.1.1 to 8.5 due to a need by 1.20.4 Fabric.
Finally, the migrateMappings command made a new src folder and copied everything over with the fixed mixins. As such I've named the old src file "oldSrc" until we decide to delete it.