Skip to content

Commit

Permalink
[Xamarin.Android.Build.Tasks] Ignore Lint MissingSuperCall (dotnet#935)
Browse files Browse the repository at this point in the history
`lint` 26.1.1 added a new MissingSuperCall check to `lint`. This
errors out if a class does NOT call `super.onCreate()`. Because
our generated code doesn't need to call `super.onCreate()`,
as the expectation is that the *managed subclass* will instead
invoke `base.OnCreate()`.
  • Loading branch information
dellis1972 authored and Redth committed Oct 30, 2017
1 parent b2f83e1 commit 4817592
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/Lint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ public Lint ()
// for the MonoPackageManager.java since we have to use a static to keep track of the
// application instance.
{ "StaticFieldLeak", new Version(26, 0, 2) },
// We need to hard code this test as disabled because Lint will issue a error
// for our generated code not calling super.OnCreate. This however is by design
// so we need to ignore this error.
{ "MissingSuperCall", new Version (26, 1, 1) },
};

static readonly Regex lintVersionRegex = new Regex (@"version[\t\s]+(?<version>[\d\.]+)");
Expand Down

0 comments on commit 4817592

Please sign in to comment.