Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.17.0 #614

Merged
merged 58 commits into from
Feb 8, 2020
Merged

Release 1.17.0 #614

merged 58 commits into from
Feb 8, 2020

Commits on Mar 31, 2019

  1. db/seeds.rb: Give restroom entries an edit_id (#567)

    Only applies during development and testing
    when we use the "db/export.csv" data.
    
    Doesn't affect production, which uses the real data in its db.
    DeeDeeG authored Mar 31, 2019
    Configuration menu
    Copy the full SHA
    b1cc32b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Explain how to run individual tests and access psql (#570)

    Also, clarify that there are two containers, web and db,
    rather than just one; these can be viewed using
    docker ps
    Kai Middleton authored and tkwidmer committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    7aaf380 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Configuration menu
    Copy the full SHA
    be1f773 View commit details
    Browse the repository at this point in the history
  2. Remove unused li

    Hkly committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    207baa4 View commit details
    Browse the repository at this point in the history
  3. Allow dropdown menu text to wrap and fit within the dropdown

    Add border bottom to give each menu item more separation
    Hkly committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    8a46a26 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2019

  1. Merge pull request #583 from Hkly/filter-focus-color

    Make filter with "focus" class more readable
    mi-wood authored Apr 27, 2019
    Configuration menu
    Copy the full SHA
    3c406be View commit details
    Browse the repository at this point in the history
  2. Merge pull request #584 from Hkly/word-wrap-dropdown-menu

    Word wrap dropdown menu
    mi-wood authored Apr 27, 2019
    Configuration menu
    Copy the full SHA
    e1d35b9 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2019

  1. Configuration menu
    Copy the full SHA
    9b2f321 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. Dockerfile: Update and streamline steps (#586)

    Does effectively the same things as before,
    but now in a simpler/faster way.
    
    Some of the changes take inspiration from
    @btyy77c's dockerAlpine branch:
    https://github.com/btyy77c/refugerestrooms/blob/dockerAlpine/Dockerfile
    
    The PhantomJS install is based on (mostly copy-pasted from)
    @nkovacs' phantomjs image from Docker Hub:
    https://github.com/nkovacs/selenium-standalone-phantomjs/blob/c5f6bba218472270/Dockerfile#L19-L22
    DeeDeeG authored May 27, 2019
    Configuration menu
    Copy the full SHA
    16b9bde View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. Dockerfile: Get latest Node.js in a major version (#589)

    (Also installs Node.js in /usr/local/
    instead of installing Node.js in the root directory.)
    
    With this updated script, we specify just a major version
    and the script picks the latest minor/patch version within that.
    
    --
    
    Nodejs.org does most of the work by maintaining the "latest-v[MAJOR]"
    folders; We only need to parse the "SHASUMS256.txt" file from there,
    and pick the "linux-x64" variant, which works with our Docker setup.
    
    At this point we can use the known directory URL, plus the filename
    extracted from "SHASUMS256.txt", and download with curl, or wget, etc.
    
    (e.g. "curl -L https://nodejs.org/dist/latest-v10.x/node-v10.16.0-linux-x64.tar.xz -o nodejs.tar.xz")
    
    --
    
    There is no "latest-LTS" folder or similar, so automatically getting
    the latest LTS version would be more difficult.
    
    We could search "nodejs.org/dist/" for folders with
    the name "latest-[LETTERS-ONLY-STRING]", which would be the folders
    of all the LTS codenames. Among these, the one with
    the alphabetically last name is the latest LTS.
    
    This would work at least until around 2040, when they may have
    to loop around and re-use some earlier letters (a, b, c, etc.)
    DeeDeeG authored Aug 20, 2019
    Configuration menu
    Copy the full SHA
    c02db62 View commit details
    Browse the repository at this point in the history
  2. Update Node.js and Ruby dependencies (#590)

    * yarn.lock: Update Node.js packages
    
    * Gemfile.lock: Update gems
    DeeDeeG authored Aug 20, 2019
    Configuration menu
    Copy the full SHA
    03d8933 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Add Bugsnag to readme

    To fufill the open source agreement, we have to link to bugsnag now in our readme.
    tkwidmer authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    4d722df View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2019

  1. .travis.yml: Use minimal base image for Travis CI

    We do all the setup/build steps inside a Docker container,
    so we don't need ruby tools outside of Docker
    (on the Travis CI virtual machine instances).
    
    Should save about 20 seconds of Travis CI build time.
    
    --
    
    Inspired by @btyy77c who did this first at their dockerAlpine branch:
      - btyy77c@393cf46
    
    Documentation at Travis re: minimal/generic images:
      - https://docs.travis-ci.com/user/languages/minimal-and-generic/
    DeeDeeG committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    ca942b3 View commit details
    Browse the repository at this point in the history
  2. docker-compose.yml: Use postgresql:alpine image

    This (the Alpine Linux-based postgresql image) is a smaller image
    than the debian-based postgresql image,
    so it should be marginally faster to download.
    
    Seems like a good idea in general,
    to speed up build times (even outside of Travis CI).
    
    Also should save some disk space for developers.
    
    --
    
    Inspired by the general concept of @btyy77c's dockerAlpine branch:
      - https://github.com/btyy77c/refugerestrooms/commits/dockerAlpine
    
    Docker Hub documentation on the alpine vs debian postgres images:
      - https://hub.docker.com/_/postgres#image-variants
    DeeDeeG committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    4b86b63 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #591 from DeeDeeG/faster-travis-ci

    Faster Travis CI builds
    DeeDeeG authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    c6cf8d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f3f942 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    384740e View commit details
    Browse the repository at this point in the history
  6. en/footer.en.yml: Remove string for tumblr blog

    This isn't needed anymore,
    since we have removed the tumblr link from the footer.
    DeeDeeG committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    89f9162 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #592 from DeeDeeG/remove-tumblr

    Remove tumblr link from footer html, related places in the code
    DeeDeeG authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    7074c49 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. removed tumblr from about page (#593)

    I noticed we were removing tumblr, here's one more instance
    Joe Wadcan authored and tkwidmer committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    7fd61d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. Create about.fil.yml (#465)

    vinzruzell authored and DeeDeeG committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b7359cc View commit details
    Browse the repository at this point in the history
  2. Filipino Translation devise.fil.yml (#454)

    * Create devise.fil.yml
    
    * Update devise.fil.yml
    
    * Update for devise.fil.yml @100% Translation
    
    * Update and rename devise.fil.yml to devise.fl.yml
    
    * Update and rename devise.fl.yml to devise.fil.yml
    vinzruzell authored and DeeDeeG committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b80146f View commit details
    Browse the repository at this point in the history
  3. 100% completed for restroom.fil.yml file (#467)

    * Create restroom.fil.yml
    vinzruzell authored and DeeDeeG committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    4fc16ae View commit details
    Browse the repository at this point in the history
  4. Translations for EN to FIL Issue 451 (#556)

    Translated files from EN to FIL #451
    hnarasaki authored and DeeDeeG committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    d4957e1 View commit details
    Browse the repository at this point in the history
  5. config/locales/fil/: Remove tumblr

    See #592 and #593
    DeeDeeG committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    d8a4cfe View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. Configuration menu
    Copy the full SHA
    3e46d8d View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. switched sass-rails gem (#595)

    * switched sass-rails gem (sass-rails --> sassc-rails)
    btyy77c authored and DeeDeeG committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    db3e900 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Configuration menu
    Copy the full SHA
    b941f43 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Configuration menu
    Copy the full SHA
    ef24b4b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Configuration menu
    Copy the full SHA
    8f9e765 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #596 from brynmrk/updated_filipino_translations

    Updated filipino translations
    DeeDeeG authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    56e5cbc View commit details
    Browse the repository at this point in the history
  3. config/application.rb: Add 'fil' locale (Filipino)

    Enables translations as merged in #596
    DeeDeeG authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    96d4dcc View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. .travis.yml: Set "dist" to "trusty" (#600)

    Should allow our CI tests to pass
    while we investigate test failures on xenial and newer.
    DeeDeeG authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    ac8f6ab View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2019

  1. Configuration menu
    Copy the full SHA
    9b76d05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a71013b View commit details
    Browse the repository at this point in the history
  3. production.rb: I18n fallbacks for :tl --> :fil

    We don't maintain separate translations for
    "Tagalog" and Filipino, since they are arguably the same language.
    
    However, Firefox only allows users to set "Tagalog" as preferred,
    and Chrome only allows users to set "Filipino" as preferred.
    
    To support both browsers, we must support both the "Tagalog"
    and the "Filipino" locales.
    
    (These locales use the "tl" and "fil" locale codes, respectively.)
    DeeDeeG committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    7378cda View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c4e9d20 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #599 from DeeDeeG/i18n-fallbacks

    Set up internationalization (i18n) fallbacks, including Tagalog --> Filipino
    DeeDeeG authored Oct 26, 2019
    Configuration menu
    Copy the full SHA
    15e2e42 View commit details
    Browse the repository at this point in the history
  6. package.json: Update swagger to master with patch

    * yarn.lock: Commit updated (indirect) dependencies
    DeeDeeG committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    17f8762 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2a56975 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    701d9df View commit details
    Browse the repository at this point in the history
  9. Merge pull request #597 from DeeDeeG/update-dependencies

    Update some dependencies
    DeeDeeG authored Oct 26, 2019
    Configuration menu
    Copy the full SHA
    1750825 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c388c97 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    792ed5b View commit details
    Browse the repository at this point in the history
  12. Dockerfile: Work around an issue with phantomjs

    When running the tests, cliver tries to check that PhantomJS's version
    is within a certain range, by running "phantomjs --version".
    
    The "phantomjs --version" command fails for some reason
    on the new ruby:2.5.7-slim Docker base image.
    
    Perhaps because the new Docker image is based on Debian 10 "Buster,"
    whereas the old Docker image was based on Debian 9 "Stretch"?
    
    This commit's workaround allows "phantomjs --version" to work again.
    DeeDeeG committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    77715cb View commit details
    Browse the repository at this point in the history
  13. Merge pull request #598 from DeeDeeG/ruby-2.5.7

    Ruby: Upgrade from 2.5.3 to 2.5.7
    DeeDeeG authored Oct 26, 2019
    Configuration menu
    Copy the full SHA
    05c74cb View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Configuration menu
    Copy the full SHA
    7381796 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Fix Travis tests failing on distributions other than trusty (#606)

    * Revert ".travis.yml: Set "dist" to "trusty" (#600)"
    
    This reverts commit ac8f6ab.
    
    Doing this to run tests on Travis to investigate why they
    aren't passing.
    
    * Explicitly require locations.rb in rspec.rb
    
    Tentative fix for tests not passing in xenial but passing in trusty.
    This might be because different distributions load files in a
    different order. In xenial, `rspec.rb` might get loaded before
    `locations.rb`, making `Locations` uninitialized. Explicit require
    fixes this.
    stardust66 authored and tkwidmer committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    6c96368 View commit details
    Browse the repository at this point in the history
  2. Dockerfile: Upgrade Node from v10.x to v12.x (#603)

    Node 12 "Erbium" is the newest Long Term Service release.
    
    We should either pin a version of Node in our package.json file,
    or stay on the latest LTS version of Node;
    
    Heroku will use the latest LTS version of Node 
    in production if we don't have any versions pinned in our package.json
    DeeDeeG authored Nov 1, 2019
    Configuration menu
    Copy the full SHA
    5154cd1 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2019

  1. Webpack Upgrade (#607)

    * Updated webpacker gem
    
    * Upgraded yarn packages
    
    * Ran webpack:install process.  Working without rails-erb-loader
    
    * Added rails-erb-loader to webpack
    
    * Fixed include PgSearch warning
    
    * Added .dockerignore
    btyy77c authored and DeeDeeG committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    01c3c21 View commit details
    Browse the repository at this point in the history
  2. PR #607: Minor tweaks/cleanup

    - Adjust Gemfile[.lock] to specify webpacker within the 4.x series,
      rather than any version 4.0 or greater.
    
    - Delete some duplicate entries in the .gitignore file
    DeeDeeG committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c6dc441 View commit details
    Browse the repository at this point in the history
  3. CONTRIBUTING.md: Remove the reference to "Cmd + C"

    The "Cmd + C" keyboard shortcut is for copying text,
    not quitting programs in the terminal.
    
    The proper way to quit programs in the terminal
    under macOS is "Ctrl + C", the same as Linux.
    
    Referring to "Cmd + C" here was based on
    a mistaken assumption that "Ctrl" on Windows or Linux
    always gets translated to "Cmd" on macOS.
    
    (In fact, some uses of "Ctrl" on Windows/Linux
    are preserved as-is on macOS. It's a mixed bag.)
    
    Deleting the reference to "Ctrl + C", to make the guidance clearer.
    DeeDeeG authored Dec 21, 2019
    Configuration menu
    Copy the full SHA
    da6e0e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2019

  1. db/schema.rb: Commit with underscores in date

    The date gets underscores added automatically
    when running migrations on the database.
    
    Committing with the underscores so the change isn't flagged by git
    when no code has been changed.
    DeeDeeG committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    297980c View commit details
    Browse the repository at this point in the history
  2. restrooms_spec.rb: Fix a test (#608)

    Background:
    
    The Mission Creek Cafe in San Francisco has been closed for some time.
    
    Google Maps API now resolves "Mission Creek Cafe"
    to a coffee shop in Washington state.
    
    Washington is too far away from our stub restroom entries;
    No stub restrooms are located near Washington,
    so no restroom results are shown on our results page for this search.
    
    The test expects to see a stub restroom entry on the reults page,
    but does not see it, and so the test fails.
    
    ---
    
    Fix:
    
    search the Maps API for "San Francisco," not "Mission Creek Cafe"
    
    (This returns a lat/long associated with San Francisco not Washington)
    DeeDeeG authored Dec 24, 2019
    Configuration menu
    Copy the full SHA
    3714303 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. Update some dependencies, fix some deprecation warnings (#609)

    * Gemfile[.lock]: Update simplecov
    
    Fixes a deprecation warning
    
    * restrooms_spec.rb: Use 'successful' not 'success'
    
    Rspec's `be_success` and `.success?` are deprecated.
    
    Rspec's `be_successful` and `.successful?`
    are the non-deprecated versions of this check.
    
    (This fixes the associated deprecation warning)
    
    * Gemfile.lock: Bump some dependencies
    
    Upgraded loofah, puma, rack, and rack-cors,
    plus their dependencies.
    DeeDeeG authored Jan 5, 2020
    Configuration menu
    Copy the full SHA
    89c8355 View commit details
    Browse the repository at this point in the history
  2. Tweak CSS a bit for narrow screens (e.g. mobile phones) (#610)

    * CSS: Add some styles for narrow screens
    
    For screen widths ~340px or narrower.
    
    (Such a narrow screen is found, for example, on the original iPhone
    through to the iPhone 5S and iPhone SE.)
    
    - Makes the "+" icon on the "Add A Restroom" button
      appear in a more correct-looking position.
    
    - Fixes the overlap of the "Refuge Restrooms" text
      with the "hamburger" drop-down menu button in the header/nav section.
    
    - Adds a class via the haml source (.nav-column)
      to make applying one of the style rules easier.
    
    * CSS: No double-padding on nested `.container`s
    
    Eliminate double-padding in cases of
    an [element].container immediately inside another [element].container.
    
    (Doing this only directly under the header div, just to be conservative.)
    
    The 15px + 15px = 30px of padding on both sides
    seemed unintentionally wide. Also, I think this looks nicer.
    Helps with the tight fit on mobile devices, too.
    
    (Should affect the header/nav on all pages other than the home page,
    aka the splash page, due to the way the pages are coded.)
    DeeDeeG authored Jan 5, 2020
    Configuration menu
    Copy the full SHA
    61e5df4 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. CSS: Center logo and brand name on narrow screens (#611)

    * _mobile.scss: Lower logo/brand on narrow screens
    
    Adjust the CSS "top" property to set the logo and "brand name"
    ("Refuge Restrooms") slightly lower within the navbar on narrow
    screens.
    
    This is to adjust for the navbar being responsively taller
    on narrower screens. "767px screen width" happens to be the responsive
    threshold for that height change for the navbar.
    
    * _mobile.scss: Move 342px rules, adjust whitespace
    
    Moved the "max 342px" rules to the bottom, so all screen-width-related
    style rules are in descending order of the sizes that they apply to.
    (For consistency).
    
    Adjusted the use of newlines in this stylesheet to be more consitent.
    DeeDeeG authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    dd5441e View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. Merge branch 'master' into release-1.17.0

    Fix merge conflicts.
    DeeDeeG committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    b38627d View commit details
    Browse the repository at this point in the history