-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of s3-deploy's "--file-prefix" #147
base: master
Are you sure you want to change the base?
Conversation
Oh, also relevant: it looks to me like s3-deploy is... dead and gone? Maybe? Their homepage was https://github.com/import-io/s3-deploy and that doesn't exist anymore. Does that pose a problem for this action? And would you ever consider moving it to the aws command-line SDK? |
Yep, we're aware that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please resolve conflicts?
This implements the missing s3-deploy
--file-prefix
flag, per request in #99 and #21.Worth noting, however: The --delete-removed flag being
true
seems to just delete everything that you just uploaded for some reason. I do not know why. I guess you need to give it a glob pattern somehow, but I don't think I really need it so I didn't do more testing.