Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of s3-deploy's "--file-prefix" #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Offlein
Copy link

@Offlein Offlein commented Mar 6, 2023

This implements the missing s3-deploy --file-prefix flag, per request in #99 and #21.

Worth noting, however: The --delete-removed flag being true seems to just delete everything that you just uploaded for some reason. I do not know why. I guess you need to give it a glob pattern somehow, but I don't think I really need it so I didn't do more testing.

@Offlein
Copy link
Author

Offlein commented Mar 6, 2023

Oh, also relevant: it looks to me like s3-deploy is... dead and gone? Maybe? Their homepage was https://github.com/import-io/s3-deploy and that doesn't exist anymore.

Does that pose a problem for this action? And would you ever consider moving it to the aws command-line SDK?

package.json Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@coliff coliff requested a review from Reggionick March 7, 2023 00:09
@coliff coliff added the enhancement New feature or request label Mar 7, 2023
@coliff
Copy link
Collaborator

coliff commented Mar 7, 2023

Oh, also relevant: it looks to me like s3-deploy is... dead and gone? Maybe? Their homepage was import-io/s3-deploy and that doesn't exist anymore.

Does that pose a problem for this action? And would you ever consider moving it to the aws command-line SDK?

Yep, we're aware that import-io/s3-deploy is gone and the npm package not being updated. I think at some point this GitHub Action will need to change to continue working as the one being used now relies on a deprecated version of the AWS JS SDK.

@coliff coliff self-requested a review March 7, 2023 13:35
Copy link
Owner

@Reggionick Reggionick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants