Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Added the pseudo quantile Huber loss #13

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[Feature] Added the pseudo quantile Huber loss #13

merged 2 commits into from
Aug 2, 2024

Conversation

bbeomjin
Copy link
Contributor

@bbeomjin bbeomjin commented Aug 2, 2024

Added the pseudo quantile Huber loss.
It generally performs better than check loss due to using an approximated Hessian (check loss uses 1 for Hessian)

@RektPunk RektPunk changed the title Added the pseudo quantile Huber loss [Feature] Added the pseudo quantile Huber loss Aug 2, 2024
@RektPunk RektPunk self-assigned this Aug 2, 2024
RektPunk
RektPunk requested changes Aug 2, 2024
View reviewed changes
Copy link
Owner

@RektPunk RektPunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. I really appreciate your contribution. But, there are some tiny things to change.

mqboost/objective.py Show resolved Hide resolved
mqboost/objective.py Outdated Show resolved Hide resolved
mqboost/objective.py Show resolved Hide resolved
mqboost/objective.py Show resolved Hide resolved
mqboost/objective.py Outdated Show resolved Hide resolved
mqboost/objective.py Outdated Show resolved Hide resolved
mqboost/objective.py Outdated Show resolved Hide resolved
RektPunk
RektPunk approved these changes Aug 2, 2024
View reviewed changes
Copy link
Owner

@RektPunk RektPunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RektPunk RektPunk merged commit a67cc6e into RektPunk:main Aug 2, 2024
@bbeomjin bbeomjin deleted the beom branch August 2, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RektPunk RektPunk RektPunk approved these changes

Assignees

@RektPunk RektPunk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbeomjin @RektPunk