add a compile-time option to enable 4k page sizes (#52229) #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
port-to-v1.10
d-netto
removed
the
port-to-master
d-netto
force-pushed
the
dcn-4k-pg-size
branch
5 times, most recently
from
39f1764
to
f02b12b
Compare
We're suffering from heavy fragmentation in some of our workloads. Add a build-time option to enable 4k pages (instead of 16k) in the GC, since that improves memory utilization considerably for us. Drawback is that this may increase the number of `madvise` system calls in the sweeping phase by a factor of 4, but concurrent page sweeping should help with some of that.
d-netto
force-pushed
the
dcn-4k-pg-size
branch
from
f02b12b
to
ef5d744
Compare
|
@kpamnany: could you approve it so that we have the basic functionality in place? Actually flipping the flag to enable it would be another PR, as usual. |
kpamnany
reviewed
Dec 5, 2023
kpamnany
approved these changes
Dec 5, 2023
Drvi
added
port-to-v1.9
Drvi
pushed a commit
that referenced
this pull request
Dec 7, 2023
…111) We're suffering from heavy fragmentation in some of our workloads. Add a build-time option to enable 4k pages (instead of 16k) in the GC, since that improves memory utilization considerably for us. Drawback is that this may increase the number of `madvise` system calls in the sweeping phase by a factor of 4, but concurrent page sweeping should help with some of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Backports upstream patch to enable 4k page sizes as a build-time option.
Checklist
Requirements for merging:
port-to-*labels that don't apply.