Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function to query page size #147

Merged
merged 1 commit into from
Apr 20, 2024
Merged

function to query page size #147

merged 1 commit into from
Apr 20, 2024

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Apr 17, 2024

PR Description

Exposes a function to get GC page size. Requested here.

Example usage:

julia> @ccall jl_get_pg_size()::UInt64
0x0000000000004000

Checklist

Requirements for merging:

@d-netto d-netto requested review from kpamnany and tveldhui April 17, 2024 15:00
@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds labels Apr 17, 2024
@d-netto
Copy link
Member Author

d-netto commented Apr 17, 2024

Just noted that we should probably upstream this. Will open another PR in JuliaLang.

@kpamnany
Copy link
Collaborator

I wonder if it would be better to just change GC_PAGE_SZ to a const int. Then accessing it doesn't even need a C call.

@d-netto d-netto removed the port-to-master This change should apply to all future Julia builds label Apr 20, 2024
@d-netto d-netto force-pushed the dcn-query-pg-size branch from 9217f81 to 19baf03 Compare April 20, 2024 02:42
@d-netto d-netto force-pushed the dcn-query-pg-size branch from 19baf03 to fb57950 Compare April 20, 2024 02:48
@d-netto d-netto merged commit bcd9f13 into v1.10.2+RAI Apr 20, 2024
6 checks passed
@d-netto d-netto deleted the dcn-query-pg-size branch April 20, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-v1.10 This change should apply to Julia v1.10 builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants