Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAI: redo prepending to backtrace output #33

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

kpamnany
Copy link
Collaborator

Correctly prepend [signal (X)] thread Y to each backtrace line that is displayed.

Correctly prepend `[signal (X)] thread Y ` to each backtrace line
that is displayed.
@kpamnany kpamnany requested review from NHDaly and d-netto August 28, 2023 16:32
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you! 👍 👍

LGTM. I'm going to start the auto-merge now, in the hopes that we can get this into the release coming this week.

@NHDaly
Copy link
Member

NHDaly commented Aug 28, 2023

EDIT: oh woops, I thought this was the RAICode PR already. Let's start that one asap and set it up for auto-merge if we can?

@kpamnany
Copy link
Collaborator Author

@kpamnany kpamnany merged commit 97251d3 into v1.9.2+RAI Aug 31, 2023
@kpamnany kpamnany deleted the kp-fix-stacktrace-prepends branch August 31, 2023 18:03
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
…g#53124)

Stdlib: ArgTools
URL: https://github.com/JuliaIO/ArgTools.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 4eccde4
New commit: 997089b
Julia version: 1.11.0-DEV
ArgTools version: 1.1.2(Does not match)
Bump invoked by: @vtjnash
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaIO/ArgTools.jl@4eccde4...997089b

```
$ git log --oneline 4eccde4..997089b
997089b fix tests for TEMP_CLEANUP, which might be a Lockable (#35)
4a5f003 build(deps): bump actions/cache from 3 to 4 (#36)
84ba9e8 Hardcode doc edit backlink (#34)
9238839 build(deps): bump actions/checkout from 3 to 4 (#33)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants