Backport gc heuristics for quick test #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements GC heuristics based on the amount of pages allocated instead of live objects like was done before. The heuristic for new heap target is based on https://dl.acm.org/doi/10.1145/3563323 (in summary it argues that the heap target should have square root behaviour). From my testing this fixes JuliaLang#49545 and JuliaLang#49761
If something odd happens during GC (the PC goes to sleep) or a very big transient the heuristics might make a bad decision. What this PR implements is if we try to make our target more than double the one we had before we fallback to a more conservative method. This fixes the new issue @vtjnash found in JuliaLang#40644 for me.
This was potentially making us getting wrong results.
github-actions
bot
added
port-to-v1.10
port-to-v1.12
d-netto
force-pushed
the
dcn-backport-gc-heuristics
branch
from
12797a5 to
08421e8
Compare
Fix unintended change Move membalancer to an ifdef Don't use square root logic because there are questions about it as well Move allocation to ratio to a number more similar to 1.9 Fix MEMBALANCER code Add GOGC like variable to control GC frequency Add null check Add the batch functions + adjust the target heap if too much gets freed out of GC + add the counted realloc size to the old gen
d-netto
force-pushed
the
dcn-backport-gc-heuristics
branch
from
594a963 to
08d4faf
Compare
d-netto
force-pushed
the
dcn-backport-gc-heuristics
branch
from
08d4faf to
747007d
Compare
|
This PR is stale because it has been open 30 days with no activity. Comment or remove stale label, or this PR will be closed in 5 days. |
d-netto
removed
port-to-v1.10
port-to-v1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Backports upstream heuristics for further testing.
Checklist
Requirements for merging:
port-to-*labels that don't apply.