columns changeable in report type "stored data" #406

Rello · Aug 30, 2024 · 1581784 · 1581784
1 parent 6a0f8b6
commit 1581784
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@
 - dark mode problems #400
 - wrong decimal handling for certain numbers #397
 - navigation css
+- columns changeable in report type "stored data" #406
 
 ## 4.14.0 - 2024-06-20
 ### Added

diff --git a/js/sidebar.js b/js/sidebar.js
@@ -226,7 +226,7 @@ OCA.Analytics.Sidebar.Report = {
                         document.getElementById('sidebarReportExportButton').style.display = 'none';
                         document.getElementById('sidebarReportNameHint').style.display = 'none';
                     } else if (data['type'] === OCA.Analytics.TYPE_INTERNAL_DB) {
-                        OCA.Analytics.Sidebar.Report.fillDatasetRelatedFields();
+                        // OCA.Analytics.Sidebar.Report.fillDatasetRelatedFields();
                     } else {
                         let optionForm = OCA.Analytics.Datasource.buildDatasourceRelatedForm(data['type']);
                         document.getElementById('reportDatasourceSection').appendChild(optionForm);
@@ -344,6 +344,9 @@ OCA.Analytics.Sidebar.Report = {
             document.getElementById('sidebarReportDatasetRow').style.display = 'table-row';
             document.getElementById('sidebarReportSubheaderRow').style.display = 'table-row';
             document.getElementById('sidebarReportParentRow').style.display = 'table-row';
+            document.getElementById('sidebarReportDimension1').disabled = true;
+            document.getElementById('sidebarReportDimension2').disabled = true;
+            document.getElementById('sidebarReportValue').disabled = true;
         } else if (datasourceType === OCA.Analytics.TYPE_GROUP) {
             document.getElementById('reportDimensionSectionHeader').style.display = 'none';
             document.getElementById('reportDatasourceSectionHeader').style.display = 'none';
@@ -360,6 +363,9 @@ OCA.Analytics.Sidebar.Report = {
             document.getElementById('sidebarReportDatasetRow').style.display = 'none';
             document.getElementById('sidebarReportSubheaderRow').style.display = 'table-row';
             document.getElementById('sidebarReportParentRow').style.display = 'table-row';
+            document.getElementById('sidebarReportDimension1').disabled = false;
+            document.getElementById('sidebarReportDimension2').disabled = false;
+            document.getElementById('sidebarReportValue').disabled = false;
         }
     },