Skip to content

Commit

Permalink
Revert "chore: Bump taffy to 0.5.2 (zed-industries#18729)" (zed-indus…
Browse files Browse the repository at this point in the history
…tries#19189)

This reverts commit a99750f.

@huacnlee found that commit to have a bad impact on perf and triaged it
for us in
zed-industries#18729 (comment)
Closes #ISSUE

Release Notes:

- N/A
  • Loading branch information
osiewicz authored Oct 14, 2024
1 parent 6ec00cd commit 792f583
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/gpui/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ smallvec.workspace = true
smol.workspace = true
strum.workspace = true
sum_tree.workspace = true
taffy = "0.5"
taffy = "0.4.3"
thiserror.workspace = true
util.workspace = true
uuid.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/gpui/src/taffy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ impl TaffyLayoutEngine {
.compute_layout_with_measure(
id.into(),
available_space.into(),
|known_dimensions, available_space, _node_id, node_context, _style| {
|known_dimensions, available_space, _id, node_context| {
let Some(node_context) = node_context else {
return taffy::geometry::Size::default();
};
Expand Down

0 comments on commit 792f583

Please sign in to comment.