Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Act on capabilities when sending requests #12

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Act on capabilities when sending requests #12

merged 11 commits into from
Jul 31, 2024

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Jul 31, 2024 •
edited
Loading

This PR includes the following things:

  • Act for more requests correct based on the capabilities that we received from the initialized response.
  • Add disconnect icon/button.
  • Fixed send correct request arguments to debug adapter when setting breakpoints.

@RemcoSmitsDev
Fix used wrong request args in set breakpoints request
e2e24b0 
Some debug adapters depend on getting the exact data that you passed in `launch` or `attach` request.
@RemcoSmitsDev
Send correct request for stopping debug adapter
700113a 
I changed the name to be more in line with the request name. We now also send the correct request values on the `support_terminate_debuggee` and `support_terminate_debuggee` capabilities.
@RemcoSmitsDev
Send disconnect request for terminate threads if it does not support it
c897c82
@RemcoSmitsDev
Only send configuration done request if its supported
38da642
@RemcoSmitsDev
Add disconnect icon
dc046f3
@RemcoSmitsDev
Only send step over request params when adapter supports it
7756b8c
@RemcoSmitsDev
Only send resume(continue) request params if adapter supports it
01f9fba
@RemcoSmitsDev
Step in only send request args if adapter supports it
e0f71d9
@RemcoSmitsDev
Step out only send request args if adapter supports it
f95d806
@RemcoSmitsDev
Step back only send request args if adapter supports it
b314426
@RemcoSmitsDev
Log error using detach_and_log_err instead of manually
1fe5616
@RemcoSmitsDev RemcoSmitsDev marked this pull request as ready for review July 31, 2024 12:55
@RemcoSmitsDev RemcoSmitsDev merged commit 1c98c1c into debugger Jul 31, 2024
0 of 4 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the act-on-capabilities-when-sending-requests branch July 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RemcoSmitsDev