Terminate thread when pane is closed/removed #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the value of the RemovedItem to contain the handle of the pane. So we can still do something with the stored values on it.
RemcoSmitsDev
changed the title
RemcoSmitsDev
deleted the
send-terminate-thread-request-when-pane-is-closed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes my original idea how to fix send terminate threads a bit. Originally, my idea was to send a new event before we removed the pane, but It turns out that event is always received late. At that point, we cannot get the pane by his ID anymore. So to fix this I have to send the handle of the pane with the removed event so we can still grab some values from the pane in any subscriber.
Screen.Recording.2024-08-04.at.11.26.25.mov
/cc @Anthony-Eid