DapAdapter Updates #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthony-Eid
force-pushed
the
debug-adapter-downloads
branch
from
1148b74
to
4010095
Compare
Co-authored-by: Remco Smits <djsmits12@gmail.com>
This is the first phase of dap::client refactor to organize debug adapters with zed lsp adapters. Eventually dap::client will have a TransportParams pass to it instead of an adapter, and adapters will handle custom debug events. Co-authored-by: Remco Smits <djsmits12@gmail.com>
This change was done to make dap::client more in line with zed's lsp::client, it might be reverted depending on if this solution is cleaner or not.
Anthony-Eid
force-pushed
the
debug-adapter-downloads
branch
from
05b602d
to
01ffebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
The aim of this PR is start making debug adapters more inline with how Zed implements LSPAdapters. This PR will start this off by setting up the automatic downloads of debug adapters (With users permission) and change our debugger implementation to use DAPBinary's.
TODO: