Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all the debug panel actions to the workspace #41

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Sep 22, 2024

This PR moves out all the actions from the debug_panel_item to the workspace which allows people to use these actions inside their key binds.

I also had to remove the debug_panel dependency inside the debug_panel_item, because we hit a "cannot update debug_panel while it is already being updated" panic. So instead of updating the thread status inside the debug_panel we now do this inside the debug_panel_item to prevent this panic.

I also move the actions to its own debugger namespace, so it's more clear what the actions are for.

The new actions can now also be used for key binds:

debugger: start
debugger: continue
debugger: step into
debugger: step over
debugger: step out
debugger: restart
debugger: stop
debugger: pause

/cc @Anthony-Eid We now can have key binds for debugger actions.

I also had to remove the debug_panel dependency inside the debug_panel_item,
because we hit a `"cannot update debug_panel while it is already being updated"` panic.

I also move the actions to its own debugger namespace, so its more clear what the actions are for.

The new actions can now also be used for key binds:
```
debugger: start
debugger: continue
debugger: step into
debugger: step over
debugger: step out
debugger: restart
debugger: stop
debugger: pause
```
@RemcoSmitsDev RemcoSmitsDev merged commit a3dff43 into debugger Sep 22, 2024
0 of 4 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the move-actions-to-workspace branch September 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant