Breakpoint prompt editor #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug occurs when a breakpoint anchor position is moved from the begining of a line. This causes dap_store.breakpoint hashmap to fail to properly get the correct element, thus toggling the wrong breakpoint. The fix to this bug is passing a breakpoint anchor to an editor's display map and to the render breakpoint function. Instead of creating a new anchor when clicking on a breakpoint icon, zed will use the breakpoint anchor passed to the display map. In the case of using toggle breakpoint action, zed will iterate through all breakpoints in that buffer to check if any are on the cursor's line number, then use anchor if found. Otherwise, zed creates a new anchor.
This bug happened when an icon {code action | code runner} was rendered on the same line of a breakpoint
where that breakpoint's anchor was not at the start of the line
Anthony-Eid
force-pushed
the
breakpoint-prompt-editor
branch
from
b857dc0
to
f73f95e
Compare
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR adds the ability to create custom messages when creating/editing a log breakpoint & fixes some bugs regarding breakpoint toggling and gutter icon overlaps.
TODO
Bugs
Log breakpoints are ignored if no breakpoints were hit prior to a log breakpoint. This is probably a setting with dap servers that we need to set as a client.
Preview
Screen.Recording.2024-10-03.at.12.17.01.AM.mov