Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module list #46

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Module list #46

merged 3 commits into from
Oct 5, 2024

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Oct 5, 2024

Screen.Recording.2024-10-05.at.13.30.37.mov

/cc @Anthony-Eid Do you know what VS Code does? I have no clue where the modules are displayed there.

I'm not sure what we should display more, but for now we display the name and the path of the module.

@RemcoSmitsDev RemcoSmitsDev marked this pull request as ready for review October 5, 2024 11:35
@Anthony-Eid
Copy link
Collaborator

Anthony-Eid commented Oct 5, 2024

Great work!! vs code shows the modules in a similar fashion, they use a drop down menu on the bottom of their debugger panel.

If module-list is only supported by some dap adapters I would make the toggle only visible when using a dap that supports that feature.

Edit:

After looking through the commit I see that you already check that a dap adapter supports module requests before giving a user the options to see them. Good stuff!

@RemcoSmitsDev RemcoSmitsDev merged commit 8c0a7b1 into debugger Oct 5, 2024
0 of 4 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the module-list branch October 5, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants