Allow users to configure host, port and timeout for build in TCP adapters
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemcoSmitsDev
changed the title
host, port and timeout
RemcoSmitsDev
changed the title
host, port and timeouthost, port and timeout for build in TCP adapters
Anthony-Eid
reviewed
Oct 27, 2024
Anthony-Eid
reviewed
Oct 27, 2024
…ne adapters This was an issue, because we stored the port arg inside the DebugAdapterBinary which was cached so could not change anymore. Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances user configurability for built-in adapters utilizing TCP transport by allowing customization of
host,port, andtimeoutsettings. Additionally, we've implemented a feature where, if no port is specified, the system will automatically attempt to locate an available port on the provided host.TODO: