fix: Don't iterate with every parameter

Remora · Nov 12, 2023 · b942471 · b942471
1 parent 8039608
commit b942471
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/Remora.Commands/Trees/Nodes/CommandNode.cs b/Remora.Commands/Trees/Nodes/CommandNode.cs
@@ -201,14 +201,13 @@ public bool TryBind
         var boundParameters = new List<BoundParameterShape>();
         while (parametersToCheck.Count > 0)
         {
+            // Because the current enumerator might be invalid or ended, we'll fix up the key-value pair here
+            var current = enumerator.MoveNext()
+                ? enumerator.Current
+                : KeyValuePair.Create(string.Empty, (IReadOnlyList<string>)Array.Empty<string>());
             var matchedParameters = new List<IParameterShape>();
             foreach (var parameterToCheck in parametersToCheck)
             {
-                // Because the current enumerator might be invalid or ended, we'll fix up the key-value pair here
-                var current = enumerator.MoveNext()
-                    ? enumerator.Current
-                    : KeyValuePair.Create(string.Empty, (IReadOnlyList<string>)Array.Empty<string>());
-
                 if (!parameterToCheck.Matches(current, out var isFatal, searchOptions))
                 {
                     if (isFatal)