Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for incoming webhook commands #345

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Add support for incoming webhook commands #345

merged 5 commits into from
Nov 3, 2024

Conversation

VelvetToroyashi
Copy link
Contributor

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 2, 2024
View reviewed changes
...ora.Discord.API.Abstractions/API/Objects/WebhookEvents/IApplicationAuthorizedWebhookEvent.cs Fixed Show fixed Hide fixed
...ora.Discord.API.Abstractions/API/Objects/WebhookEvents/IApplicationAuthorizedWebhookEvent.cs Fixed Show fixed Hide fixed
...ora.Discord.API.Abstractions/API/Objects/WebhookEvents/IApplicationAuthorizedWebhookEvent.cs Fixed Show fixed Hide fixed
...ora.Discord.API.Abstractions/API/Objects/WebhookEvents/IApplicationAuthorizedWebhookEvent.cs Fixed Show fixed Hide fixed
Backend/Remora.Discord.API.Abstractions/API/Objects/WebhookEvents/IWebhookEvent.cs Fixed Show fixed Hide fixed
Backend/Remora.Discord.API.Abstractions/API/Objects/WebhookEvents/WebhookEventPayloadType.cs
/// <summary>
/// The payload is an event with data.
/// </summary>
Event

Check notice

Code scanning / InspectCode

Type member is never used: Non-private accessibility Note

Enum member 'Event' is never used
Backend/Remora.Discord.API.Abstractions/API/Objects/WebhookEvents/WebhookEventType.cs
/// <summary>
/// The application was authorized to a user or guild.
/// </summary>
ApplicationAuthorized,

Check notice

Code scanning / InspectCode

Type member is never used: Non-private accessibility Note

Enum member 'ApplicationAuthorized' is never used
Backend/Remora.Discord.API.Abstractions/API/Objects/WebhookEvents/WebhookEventType.cs
/// <summary>
/// An entitlement was created.
/// </summary>
EntitlementCreate,

Check notice

Code scanning / InspectCode

Type member is never used: Non-private accessibility Note

Enum member 'EntitlementCreate' is never used
Backend/Remora.Discord.API.Abstractions/API/Objects/WebhookEvents/WebhookEventType.cs
/// <summary>
/// User was added to a Quest (currently unavailable).
/// </summary>
QuestUserEnrollment,

Check notice

Code scanning / InspectCode

Type member is never used: Non-private accessibility Note

Enum member 'QuestUserEnrollment' is never used
Backend/Remora.Discord.API/API/Objects/WebhookEvents/WebhookEvent.cs
namespace Remora.Discord.API.Objects;

/// <inheritdoc cref="IWebhookEvent"/>
public record WebhookEvent

Check notice

Code scanning / InspectCode

Class is never instantiated: Non-private accessibility Note

Record 'WebhookEvent' is never instantiated
@Nihlus Nihlus added the waiting for review The PR is awaiting review by maintainers label Nov 2, 2024
Nihlus
Nihlus requested changes Nov 2, 2024
View reviewed changes
Copy link
Member

@Nihlus Nihlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got a few inspections to take care of (missing PublicAPI annotations) and there's no .optionals.json test file for APPLICATION_AUTHORIZED_WEBHOOK_EVENT - otherwise, everything looks good. Thanks!

@Nihlus Nihlus added waiting for author The PR is awaiting an update from the author and removed waiting for review The PR is awaiting review by maintainers labels Nov 2, 2024
@Nihlus Nihlus merged commit 5e7bfc5 into Remora:main Nov 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nihlus Nihlus Nihlus approved these changes

Assignees
No one assigned
Labels
waiting for author The PR is awaiting an update from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VelvetToroyashi @Nihlus