#28 #34
Closed
#28 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing a quote timestamp for making an exchange reate dated.
…o support on AppVeyor
|
You have extended the ExchangeRate struct with methods to get quotes. The idea is to have very lightweight ExchangeRate object, so that we can create millions in memory with no effort. Even adding a datetime to the object is already under discussion. The direction I am looking for is the have an ExchangeRateProvider (possible linked) that will deliver the rates by date. Therefor I can't accept the pull request as it is now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #28; Introducing a quote timestamp for making an exchange rate dated.