Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openpgl exposes embree::mm_lookupmask_ps symbol #3

Open
StefanBruens opened this issue Nov 2, 2022 · 3 comments
Open

openpgl exposes embree::mm_lookupmask_ps symbol #3

StefanBruens opened this issue Nov 2, 2022 · 3 comments

Comments

@StefanBruens
Copy link

The mm_lookupmask_ps/mm_lookupmask_pd symbols are visible from libpgl:

nm -DC --defined-only /usr/lib64/libopenpgl.so.0.4.0  | grep embree
0000000000078580 B embree::mm_lookupmask_pd
0000000000076060 B embree::mm_lookupmask_ps

https://github.com/OpenPathGuidingLibrary/openpgl/blob/a1404c528b9586acdf55fc150b1cb16ab55f6bab/third-party/embreeSrc/common/simd/sse.h#L24-L25

libembree3 proper does not have this issue, as it sets default symbol visibility to "hidden".

@sherholz-intel
Copy link
Collaborator

@StefanBruens, thanks for pointing that out.
I will make sure that it will be part of the next release.

@sherholz-intel
Copy link
Collaborator

Hi @StefanBruens

could you try and see if the fix/linux-arm-and-visibility branch fixes your problem?

@StefanBruens
Copy link
Author

The options are only applied when you use a RELEASE build:
0ef25a1#diff-54334ebcaf9c58cca1d6b08404b95dcfe68b84a3bedaafbfab42fe76606b3aedR135

For Linux distributions the typical CMAKE_BUILD_TYPE is RelWithDebInfo, i.e. optimized with debug symbols.

The compiler option variables should be probably split into "common" and debug/release ones, and the common ones should be added to the target_compile_options for all CONFIGs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants