CE-1925: Update AMQPPublishProperties class to enable setting of timeout and confirmEnabled properties #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… confirmEnabled properties when overriding during a message publish. Also added builder to AMQPMessageBundle class
…e issue with nested AMQPTransportTest
…vocation possibly throwing a runtime exception" issues in unit tests
|
|
||
| AMQPPublishProperties(String exchange, String routingKey, long timeout, boolean confirmEnabled) { | ||
| public AMQPPublishProperties(String exchange, String routingKey) { |
There was a problem hiding this comment.
Should this one be private now? We could force folks to move to the builder when upgrading
There was a problem hiding this comment.
Opted to go with a non-breaking change, influence mostly by this being a public repo. But happy to change.
On review I'm actually thinking it might be a good idea for this to catch people to make them think about if their publisher config is being overridden here
…es builder usage. Limited parameter constructor could also result in inadvertent overriding of constructed publisher config at publish time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary change is to update AMQPPublishProperties so that the timeout and confirmEnabled properties can be set when publishing a message with override publish properties. The constructor setting these properties had been set as package-private.
Also