Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release #1498

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: release #1498

merged 1 commit into from
Dec 2, 2024

Conversation

rodrigopavezi
Copy link
Member

@rodrigopavezi rodrigopavezi commented Nov 30, 2024

When trying to release the SDK I could not get around the following issue.

Screenshot 2024-11-30 at 11 43 07

This PR applies the suggest fix from this issue iarna/wide-align#63

Summary by CodeRabbit

  • Chores
    • Updated nx.json to enhance project dependency management for build operations.
    • Added a resolution for the string-width package in package.json to ensure compatibility.

Copy link
Contributor

coderabbitai bot commented Nov 30, 2024

Walkthrough

The pull request introduces modifications to the nx.json and package.json configuration files. In nx.json, the cacheableOperations and dependsOn properties are updated to enhance dependency management for build operations across projects. In package.json, a new resolution for the string-width package is added, specifying version 4.2.3, while other configurations remain unchanged.

Changes

File Change Summary
nx.json Updated cacheableOperations from ["build", "test"] to ["^build", "test"]; modified dependsOn for build target to ["^build"].
package.json Added resolution for string-width package, version 4.2.3; no other changes made.

Suggested reviewers

  • kevindavee
  • alexandre-abrioux
  • sstefdev
  • MantisClone
  • yomarion

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
nx.json (1)

6-6: LGTM! Build configuration changes improve dependency handling

The addition of the ^ prefix to build in cacheableOperations ensures proper caching of dependent project builds, which should help resolve the release issues by:

  1. Enforcing correct build order across the monorepo
  2. Preventing potential race conditions during the build process
  3. Improving build performance through better caching

This change follows monorepo best practices for managing build dependencies in a large workspace.

package.json (1)

60-61: LGTM! Resolution addresses the release issue

The addition of string-width@4.2.3 to resolutions implements the fix suggested in wide-align#63, which should resolve the release issues.

Consider adding documentation for this resolution in the resolutionsDocs section, similar to other entries, to help future maintainers understand why this specific version was pinned.

  "resolutionsDocs": {
    "underscore": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/14",
    "crypto-js": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/207",
    "minimist": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/177",
    "semver": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/197",
    "json-schema": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/51",
-   "json5": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/165"
+   "json5": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/165",
+   "string-width": "https://github.com/iarna/wide-align/issues/63"
  }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1cddb53 and 84fc213.

📒 Files selected for processing (2)
  • nx.json (1 hunks)
  • package.json (1 hunks)

@rodrigopavezi rodrigopavezi merged commit 6b7ef10 into master Dec 2, 2024
28 checks passed
@rodrigopavezi rodrigopavezi deleted the fix/release branch December 2, 2024 12:11
rodrigopavezi added a commit that referenced this pull request Dec 2, 2024
@coderabbitai coderabbitai bot mentioned this pull request Dec 2, 2024
This was referenced Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants