-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: release #1498
fix: release #1498
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
nx.json (1)
6-6
: LGTM! Build configuration changes improve dependency handlingThe addition of the
^
prefix tobuild
incacheableOperations
ensures proper caching of dependent project builds, which should help resolve the release issues by:
- Enforcing correct build order across the monorepo
- Preventing potential race conditions during the build process
- Improving build performance through better caching
This change follows monorepo best practices for managing build dependencies in a large workspace.
package.json (1)
60-61
: LGTM! Resolution addresses the release issueThe addition of
string-width@4.2.3
to resolutions implements the fix suggested in wide-align#63, which should resolve the release issues.Consider adding documentation for this resolution in the
resolutionsDocs
section, similar to other entries, to help future maintainers understand why this specific version was pinned."resolutionsDocs": { "underscore": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/14", "crypto-js": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/207", "minimist": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/177", "semver": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/197", "json-schema": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/51", - "json5": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/165" + "json5": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/165", + "string-width": "https://github.com/iarna/wide-align/issues/63" }
This reverts commit 6b7ef10.
When trying to release the SDK I could not get around the following issue.
This PR applies the suggest fix from this issue iarna/wide-align#63
Summary by CodeRabbit
nx.json
to enhance project dependency management for build operations.string-width
package inpackage.json
to ensure compatibility.