feat(ipfs-manager): adapt RPC usage with POST methods #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjlevesque
commented
Jun 23, 2022
| @@ -14,7 +14,7 @@ const invalidHostIpfsGatewayConnection: StorageTypes.IIpfsGatewayConnection = { | |||
| host: 'nonexistent', | |||
| port: 5001, | |||
| protocol: StorageTypes.IpfsGatewayProtocol.HTTP, | |||
| timeout: 1000, | |||
| timeout: 1500, | |||
There was a problem hiding this comment.
not sure what changed, but without this the test fails...
benjlevesque
commented
Jun 23, 2022
| @@ -76,24 +76,24 @@ describe('Ipfs manager', () => { | |||
| it('allows to pin one file ipfs', async () => { | |||
| await ipfsManager.add(content); | |||
| const pinnedHash = await ipfsManager.pin([hash]); | |||
| expect(hash).toBe(pinnedHash[0]); | |||
| expect(pinnedHash[0]).toBe(hash); | |||
There was a problem hiding this comment.
wrong order for expect
benjlevesque
commented
Jun 23, 2022
| }); | ||
|
|
||
| it('timeout errors should not generate any retry', async () => { | ||
| it('timeout errors should generate retry', async () => { |
There was a problem hiding this comment.
IMPORTANT. We now want to retry on timeout
alexandre-abrioux
approved these changes
Jun 24, 2022
github-actions
bot
requested review from
alexandre-abrioux,
bertux,
kevindavee and
KolevDarko
benjlevesque
commented
Jun 27, 2022
| @@ -3,9 +3,9 @@ import { BigNumber } from 'ethers'; | |||
|
|
|||
| // This contains default values used to use Ethereum Network and IPFS | |||
| // if information are not provided by the user | |||
| const config: any = { | |||
| const config = { | |||
There was a problem hiding this comment.
unrelated, annying any
benjlevesque
commented
Jun 27, 2022
|
|
||
| '/dns4/ipfs-survival.request.network/tcp/4001/ipfs/Qmb6a5DH45k8JwLdLVZUhRhv1rnANpsbXjtsH41esGhNCh', | ||
| ], | ||
| expectedBootstrapNodes: { |
There was a problem hiding this comment.
the format of the address changed, this accounts for the change while supporting older format
kevindavee
approved these changes
Jun 28, 2022
bertux
approved these changes
Jun 30, 2022
benjlevesque
force-pushed
the
ipfs-rpc-post
branch
from
676ed09 to
d5d2652
Compare
alexandre-abrioux
approved these changes
Jul 4, 2022
Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modern versions of IPFS now require using POST for every calls
ipfs/kubo#7097
ipfs/js-ipfs#2971
Also in this PR: replace
axios-retrysince it seems to not retry POST requests