Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out best way to split up packages #2

Open
zaviermiller opened this issue Aug 12, 2023 · 1 comment
Open

Figure out best way to split up packages #2

zaviermiller opened this issue Aug 12, 2023 · 1 comment

Comments

@zaviermiller
Copy link
Collaborator

Right now, each independent part of this project is its own package.

I originally felt this was best since that would allow for plugin developers to only install the package(s) they need; however, now I am thinking that the hassle may not be worth it.

Do we really need 5 different packages to make this thing work?

One potential solution would be to create a separate types package that would allow devs to pull in only types if that's all they needed.

With this, though, I go back to thinking about the receipt-escpos-renderer package. There are some useful utils in there that people building their own nodes could use. Would they want to import the entire receipt-components package? I'm not sure.

None of this may even matter. The end-user will have all packages installed so does it really matter if a developer has to install slightly more on their own machine?

@jaxn
Copy link
Member

jaxn commented Aug 12, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants