Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul custom inspector generation #53

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

Banane9
Copy link
Member

@Banane9 Banane9 commented Jul 26, 2024

Make sure to update your MonkeyLoader install from master too if you want to test this.

  • Adds the AllowContainer argument to the custom inspector events
  • Places all of header generation into the event
    • Default generation is handled by the default handler
    • The positioning uses ConfigKeySessionShare components to make it appear customized (or default) for everyone
    • Places the open container button to the left by default

@Banane9 Banane9 added the enhancement New feature or request label Jul 26, 2024
@Banane9 Banane9 requested a review from Nytra July 26, 2024 18:43
@Banane9 Banane9 force-pushed the feature/overhaul-custom-inspector-injection branch from 482f6d0 to ca688d8 Compare July 27, 2024 00:25
Copy link
Contributor

@Nytra Nytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, however if the shared config gets destroyed it doesn't seem to recover correctly. It does not create the user overrides or the dynamic fields.

@Banane9
Copy link
Member Author

Banane9 commented Jul 27, 2024

Hmmm, I thought I made it so that it always checks that when creating new drives. Checking for that in every place it's used would seem like overkill.

Feel free to look into it or make an issue with more details 👀

@Banane9 Banane9 merged commit 353df55 into master Jul 27, 2024
2 checks passed
@Banane9 Banane9 deleted the feature/overhaul-custom-inspector-injection branch July 27, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants