Update some templates and improve tests #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some templates were a bit confusing, and I would like to favour adding
the `{{name}}` at the beginning of the templates as it helps when
reading nested messages.
I also deleted the regression tests for issue Respect#1348, because it's a
non-issue, actually. The best approach to that problem is indeed using
`When` insteaf of `OneOf`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
============================================
+ Coverage 96.63% 96.64% +0.01%
- Complexity 996 999 +3
============================================
Files 205 205
Lines 2467 2477 +10
============================================
+ Hits 2384 2394 +10
Misses 83 83 ☔ View full report in Codecov by Sentry. |
henriquemoody
force-pushed
the
housekeeping/messages
branch
from
7c4fc1c to
a0d6355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some templates were a bit confusing, and I would like to favour adding the
{{name}}at the beginning of the templates as it helps when reading nested messages.I also deleted the regression tests for issue #1348, because it's a non-issue, actually. The best approach to that problem is indeed using
Wheninsteaf ofOneOf.