-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The width
attribute
#268
Comments
My main concern here is that it would be nice if the computed |
If I'm understanding the suggestion properly, i.e., use the width value as the default The one suggestion I would propose, is to only use the width value when it is less than |
Thanks @joemcgill :) The change I'm proposing only relates to the |
Right, I understood, but was probably unclear in my description. I just meant that if an inline |
bump ... any blockers to resolve this? This is an important feature for Client Hints. |
I'm down with this. It makes sense to me. |
OK with me, but we should ignore it when it uses percentages (since it refers to containing block, and it's invalid anyway). Also I'm not sure I like @joemcgill's idea to have the viewport width be an upper bound, that seems unnecessary magic that could get confusing results, especially for Client Hints. You can still achieve the effect by using the |
I agree. Probably best to keep things straightforward. |
During discussions about Client-Hints, where it makes sense to include the
width
attribute in the outgoingWidth
hint, since it can be useful to retrofit responsive images to legacy sites, @foolip suggested that it may make sense to include the same logic in srcset, and I think it makes a lot of sense.Basically, the same logic applies. If
sizes
is missing andwidth
is there and contains a non-% value, we should use thewidth
value as thesource-size-value
(or add some "ifsizes
is not there, usewidth
logic to the consumer of "parse a sizes attribute".@zcorpan - WDYT?
The text was updated successfully, but these errors were encountered: