Add a debug implementation for Address #67

Restioson · 2022-04-10T13:29:35Z

This does not address MessageChannel as I just haven't looked into it yet. I'll look into it before this gets merged, though. Closes #54.

Implement Debug on RefCounter and show reference counts
Implement for MessageChannel
Add test

thomaseizinger

I think that is a good starting point. Implementing Debug on RefCounter could also be interesting to see the actual refcount.

Restioson · 2022-04-10T21:29:01Z

That makes sense

# Conflicts: # src/message_channel.rs

Restioson · 2022-05-21T16:19:06Z

Is this what you were thinking of when it comes to the reference count debugging @thomaseizinger ?

thomaseizinger · 2022-05-22T10:26:36Z

Yeah this looks good! Perhaps we can add a test that asserts the Debug implementation? This would make it even easier to review and we make sure it is not broken :)

src/address.rs

Restioson · 2022-05-22T21:30:40Z

Sounds like a good plan

Restioson · 2022-05-29T17:20:49Z

I've added a test for this now. One remaining unresolved question is whether to report the weak count strictly accurately (i.e number of weak references, incl. the one kept inside Context), or to make it count the number of weak addresses (statically one less than the strict count).

thomaseizinger · 2022-05-29T18:52:52Z

I've added a test for this now. One remaining unresolved question is whether to report the weak count strictly accurately (i.e number of weak references, incl. the one kept inside Context), or to make it count the number of weak addresses (statically one less than the strict count).

I think reporting the actual number of addresses is good enough. I see very little foot-gun potential here :)

tests/basic.rs

# Conflicts: # examples/basic_wasm_bindgen/src/lib.rs

thomaseizinger

Implementation looks good to me :)

examples/basic_wasm_bindgen/src/lib.rs

src/refcount.rs

tests/basic.rs

@thomaseizinger

Thanks to @thomaseizinger! Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

…o debug_address

Restioson · 2022-06-09T13:15:21Z

Going to go ahead and merge this now if CI passes

Technically this is not an MSRV issue, this is an actions + not commiting Cargo.lock issue, since having async_global_executor on 2021 should be fine as long as your compiler is also on 2021, and xtra won't specifically bring in the 2021 edition as it.

Restioson · 2022-06-09T17:33:46Z

I'm pretty confident that CI will pass once #80 lands, since the current failure has nothing to do with any code changes in this branch, so I am going to go ahead and merge this now.

@thomaseizinger

* Add a debug implementation for Address * fmt * Ensure debug works for messagechannel & show RC info * format * Add test * Remove refcounter type from struct name * Ensure debug works for messagechannel & show RC info * Fix rebase issue * Turbofish over type annotation (@thomaseizinger) Thanks to @thomaseizinger! Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Remove unnecessary locking * rustfmt * Try fix MSRV issue * Revert (original change red herring) Technically this is not an MSRV issue, this is an actions + not commiting Cargo.lock issue, since having async_global_executor on 2021 should be fine as long as your compiler is also on 2021, and xtra won't specifically bring in the 2021 edition as it. Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

@thomaseizinger

* Add a debug implementation for Address * fmt * Ensure debug works for messagechannel & show RC info * format * Add test * Remove refcounter type from struct name * Ensure debug works for messagechannel & show RC info * Fix rebase issue * Turbofish over type annotation (@thomaseizinger) Thanks to @thomaseizinger! Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Remove unnecessary locking * rustfmt * Try fix MSRV issue * Revert (original change red herring) Technically this is not an MSRV issue, this is an actions + not commiting Cargo.lock issue, since having async_global_executor on 2021 should be fine as long as your compiler is also on 2021, and xtra won't specifically bring in the 2021 edition as it. Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

@thomaseizinger

* Addresses are sinks POC (based on flume changes) * Add a debug implementation for Address (#67) * Add a debug implementation for Address * fmt * Ensure debug works for messagechannel & show RC info * format * Add test * Remove refcounter type from struct name * Ensure debug works for messagechannel & show RC info * Fix rebase issue * Turbofish over type annotation (@thomaseizinger) Thanks to @thomaseizinger! Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Remove unnecessary locking * rustfmt * Try fix MSRV issue * Revert (original change red herring) Technically this is not an MSRV issue, this is an actions + not commiting Cargo.lock issue, since having async_global_executor on 2021 should be fine as long as your compiler is also on 2021, and xtra won't specifically bring in the 2021 edition as it. Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Minimal 2021 edition update, MSRV -> 1.56, GHA update (#80) * Minimal ed2021 update, and MSRV -> 1.56 * Set MSRV in Cargo.toml * Use minimal versions for all CI runs * typo * Update minimum dep for basic_wasm_bindgen console_error_panic_hook < 0.1.5 was nightly only. This change was needed to make CI with minimum versions pass. Really, it's a little unnecessary for an example to have an MSRV, but to make this CI work with the fewest modifications it's the easiest option. * Update to HEAD of flume fork * Sink for Handler<Return = ()> only * Add example showcasing usage of `Address` as `Sink` * Add example for sending on an interval based on stream * Add a debug implementation for Address (#67) * Add a debug implementation for Address * fmt * Ensure debug works for messagechannel & show RC info * format * Add test * Remove refcounter type from struct name * Ensure debug works for messagechannel & show RC info * Fix rebase issue * Turbofish over type annotation (@thomaseizinger) Thanks to @thomaseizinger! Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Remove unnecessary locking * rustfmt * Try fix MSRV issue * Revert (original change red herring) Technically this is not an MSRV issue, this is an actions + not commiting Cargo.lock issue, since having async_global_executor on 2021 should be fine as long as your compiler is also on 2021, and xtra won't specifically bring in the 2021 edition as it. Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Addresses are sinks POC (based on flume changes) * Fmt * update examples (Address is no longer Sync) * Fmt * 1.56 compliance (for CI) * Update flume to crates.io Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

Add a debug implementation for Address

21fba4b

Restioson self-assigned this Apr 10, 2022

Restioson added the enhancement New feature or request label Apr 10, 2022

Restioson added this to the 0.6.0 milestone Apr 10, 2022

Restioson mentioned this pull request Apr 10, 2022

Could Address implement fmt::Debug? #54

Closed

fmt

a34e8cb

thomaseizinger reviewed Apr 10, 2022

View reviewed changes

Restioson added 3 commits May 21, 2022 18:09

Ensure debug works for messagechannel & show RC info

1a44274

Merge branch 'master' into debug_address

6b6c38e

# Conflicts: # src/message_channel.rs

format

3f7c73d

thomaseizinger reviewed May 22, 2022

View reviewed changes

src/address.rs Outdated Show resolved Hide resolved

Add test

fb51705

thomaseizinger reviewed May 29, 2022

View reviewed changes

tests/basic.rs Outdated Show resolved Hide resolved

thomaseizinger reviewed May 29, 2022

View reviewed changes

tests/basic.rs Outdated Show resolved Hide resolved

thomaseizinger reviewed May 29, 2022

View reviewed changes

tests/basic.rs Outdated Show resolved Hide resolved

Restioson added 4 commits June 4, 2022 13:40

Remove refcounter type from struct name

3df7d0a

Ensure debug works for messagechannel & show RC info

10d43e0

Fix rebase issue

c10e8fc

Merge branch 'master' into debug_address

cb1bd62

# Conflicts: # examples/basic_wasm_bindgen/src/lib.rs

thomaseizinger approved these changes Jun 5, 2022

View reviewed changes

examples/basic_wasm_bindgen/src/lib.rs Outdated Show resolved Hide resolved

src/refcount.rs Outdated Show resolved Hide resolved

tests/basic.rs Outdated Show resolved Hide resolved

Restioson and others added 3 commits June 5, 2022 18:16

Turbofish over type annotation (@thomaseizinger)

b3e7446

Thanks to @thomaseizinger! Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

Remove unnecessary locking

cc60757

Merge branch 'debug_address' of https://github.com/Restioson/xtra int…

9489f85

…o debug_address

Restioson added 3 commits June 9, 2022 15:15

rustfmt

92caee1

Try fix MSRV issue

c2dfb10

Restioson merged commit 0e51b00 into master Jun 9, 2022

Restioson deleted the debug_address branch June 13, 2022 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a debug implementation for Address #67

Add a debug implementation for Address #67

Restioson commented Apr 10, 2022 •

edited

Loading

thomaseizinger left a comment

Restioson commented Apr 10, 2022

Restioson commented May 21, 2022

thomaseizinger commented May 22, 2022

Restioson commented May 22, 2022

Restioson commented May 29, 2022

thomaseizinger commented May 29, 2022

thomaseizinger left a comment

Restioson commented Jun 9, 2022

Restioson commented Jun 9, 2022

Add a debug implementation for Address #67

Add a debug implementation for Address #67

Conversation

Restioson commented Apr 10, 2022 • edited Loading

thomaseizinger left a comment

Choose a reason for hiding this comment

Restioson commented Apr 10, 2022

Restioson commented May 21, 2022

thomaseizinger commented May 22, 2022

Restioson commented May 22, 2022

Restioson commented May 29, 2022

thomaseizinger commented May 29, 2022

thomaseizinger left a comment

Choose a reason for hiding this comment

Restioson commented Jun 9, 2022

Restioson commented Jun 9, 2022

Restioson commented Apr 10, 2022 •

edited

Loading