Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perform rc_client hash resolution locally, then pass hash to external interface #359

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jul 25, 2024

Alternate solution to #358.

Allows hash generation to occur in the local environment, and then automatically calls the external methods that accept a hash instead of a buffer. This way, any client-specific hashing logic (such as CHD support) doesn't have to be accessible from the external implementation.

For example, instead of rc_client_begin_identify_and_load_game calling through to external_client->begin_identify_and_load_game, it generates the hash locally and calls external_client->begin_load_game. This change also affects rc_client_begin_change_media

Since these changes are all done internally to the rc_client functions, no additional work is required in the calling code.

https://discord.com/channels/476211979464343552/757767535293890682/1265528322943881306

@Jamiras Jamiras added this to the 11.5.0 milestone Jul 25, 2024
@Jamiras Jamiras merged commit 22f0597 into RetroAchievements:develop Jul 27, 2024
7 checks passed
@Jamiras Jamiras deleted the feature/rc_client_rainteg_load_handoff branch July 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant