perform rc_client hash resolution locally, then pass hash to external interface #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate solution to #358.
Allows hash generation to occur in the local environment, and then automatically calls the external methods that accept a hash instead of a buffer. This way, any client-specific hashing logic (such as CHD support) doesn't have to be accessible from the external implementation.
For example, instead of
rc_client_begin_identify_and_load_game
calling through toexternal_client->begin_identify_and_load_game
, it generates the hash locally and callsexternal_client->begin_load_game
. This change also affectsrc_client_begin_change_media
Since these changes are all done internally to the
rc_client
functions, no additional work is required in the calling code.https://discord.com/channels/476211979464343552/757767535293890682/1265528322943881306